docs(runtime): correct public imports and composition entry point - #5142
Open
MasamiYui wants to merge 1 commit into
Open
docs(runtime): correct public imports and composition entry point#5142MasamiYui wants to merge 1 commit into
MasamiYui wants to merge 1 commit into
Conversation
Generated-by: OpenAI Codex
me2seeks
reviewed
Sep 11, 2026
Contributor
There was a problem hiding this comment.
PR 5142 Review
结论
APPROVE
Docs-only：packages/runtime/README.md 的 root-barrel 误述（@maka/runtime 实际无 root export）已修正，补上可解析的 subpath 导入示例，并把 composition 指针从 Desktop main 换到真正的共享 composition 文件。
发现
[P3] 与 #5165、#5200 修同一缺陷、同一文件（issue #5141），三者不能同时合并
- 文件: packages/runtime/README.md
- 问题：本 PR、#5165、#5200 都只改
packages/runtime/README.md的 "Public seam" 段，修的是同一个 root-barrel 误述（同一 issue #5141）。三个 PR 不能同时合并，后合者会因同段改动产生 diff 冲突。 - 建议：维护者三选一合并，其余关闭即可。三者内容无分歧、本 PR 改动最克制。纯流程提示，不影响本 PR 技术正确性。
验证
package.json#exports无'.'键 → root 确实不导出，原文档说法确为缺陷。./session-manager→./dist/session-manager.js、./ai-sdk-backend→./dist/ai-sdk-backend.js，两个 subpath 均声明存在。SessionManager（src/session-manager.ts:898）、AiSdkBackend（src/ai-sdk-backend.ts:283）真实导出，示例导入的两个命名都存在。- 新增相对链接指向的
packages/runtime-host/src/server/execution-composition.ts存在，且其中确实构造SessionManager/BackendRegistry。 - 仅删除被证伪的 root-barrel 声明并补正确 subpath，无多余抽象。
This was referenced Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Runtime README described a supported package-root import even though
@maka/runtimehas no root export, and pointed contributors to Desktop main for Runtime composition.This corrects both root-barrel references, adds explicit
SessionManagerandAiSdkBackendsubpath import examples, and links the shared Runtime Host execution composition. The change is limited topackages/runtime/README.md; runtime behavior is unchanged.Fixes #5141
Verification
Verified on macOS 26.6.2 / Node.js v23.7.0, against base
f09119884and this branch:import('@maka/runtime')rejects withERR_PACKAGE_PATH_NOT_EXPORTED, confirming the existing documentation defect.SessionManagerandBackendRegistry.git diff --check HEAD^ HEADpasses.The subpath checks cover resolution and source declarations, not execution of compiled Runtime modules. Full lint, formatter, typecheck, build, and workspace test suites were not run for this Markdown-only change.
Before and after screenshots — actual GitHub Markdown preview
Before — base README
After — updated README
Screenshots are stored on a separate evidence branch in the fork and are not part of this PR's file changes.
AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex inspected the package exports and composition, edited the README, ran the focused verification, and captured the screenshots. The commit includes
Generated-by: OpenAI Codex.Automated PR submission by OpenAI Codex on behalf of @MasamiYui, the human contributor of record.
Checklist
Does this PR entail a change in behavior?